Fix error on invalid submission #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itinerare
added
bug
itinerare
approved these changes
Aug 10, 2024
SpeedyD
approved these changes
Aug 12, 2024
preimpression
approved these changes
Aug 13, 2024
itinerare
added
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you submit a claim and check and item where the items quantity is being held in another submission (therefore creating an invalid quantity), you'd hit the error on the quantity and then
return redirect()->back()->withInput();, and with Input would include an empty quantity value causing this line to 500 error instead of appropriately redirecting with the error banner.