fix(characters): make sale value always editable (#781)

* suggestion(character): Sale value switch gets removed * forgot the backslash, pardon * refactor: fix blade formatting --------- Co-authored-by: SpeedyD <[email protected]>
corowne · Jan 3, 2024 · 100abc0 · 100abc0
1 parent fbbf5b4
commit 100abc0
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 35 deletions.
diff --git a/resources/views/character/_tab_stats.blade.php b/resources/views/character/_tab_stats.blade.php
@@ -21,15 +21,26 @@
 
 <hr />
 
-<h5><i class="text-{{ $character->is_giftable ? 'success far fa-circle' : 'danger fas fa-times' }} fa-fw mr-2"></i> {{ $character->is_giftable ? 'Can' : 'Cannot' }} be gifted</h5>
-<h5><i class="text-{{ $character->is_tradeable ? 'success far fa-circle' : 'danger fas fa-times' }} fa-fw mr-2"></i> {{ $character->is_tradeable ? 'Can' : 'Cannot' }} be traded</h5>
-<h5><i class="text-{{ $character->is_sellable ? 'success far fa-circle' : 'danger fas fa-times' }} fa-fw mr-2"></i> {{ $character->is_sellable ? 'Can' : 'Cannot' }} be sold</h5>
-<div class="row">
-    <div class="col-lg-3 col-4">
-        <h5>Sale Value</h5>
+
+<h5>
+    <i class="text-{{ $character->is_giftable ? 'success far fa-circle' : 'danger fas fa-times' }} fa-fw mr-2"></i> {{ $character->is_giftable ? 'Can' : 'Cannot' }} be gifted
+</h5>
+<h5>
+    <i class="text-{{ $character->is_tradeable ? 'success far fa-circle' : 'danger fas fa-times' }} fa-fw mr-2"></i> {{ $character->is_tradeable ? 'Can' : 'Cannot' }} be traded
+</h5>
+<h5>
+    <i class="text-{{ $character->is_sellable ? 'success far fa-circle' : 'danger fas fa-times' }} fa-fw mr-2"></i> {{ $character->is_sellable ? 'Can' : 'Cannot' }} be sold
+</h5>
+@if ($character->sale_value > 0)
+    <div class="row">
+        <div class="col-lg-3 col-4">
+            <h5>Sale Value</h5>
+        </div>
+        <div class="col-lg-9 col-8">
+            {{ Config::get('lorekeeper.settings.currency_symbol') }}{{ $character->sale_value }}
+        </div>
     </div>
-    <div class="col-lg-9 col-8">{{ config('lorekeeper.settings.currency_symbol') }}{{ $character->sale_value }}</div>
-</div>
+@endif
 @if ($character->transferrable_at && $character->transferrable_at->isFuture())
     <div class="row">
         <div class="col-lg-3 col-4">

diff --git a/resources/views/character/admin/_edit_stats_modal.blade.php b/resources/views/character/admin/_edit_stats_modal.blade.php
@@ -44,11 +44,9 @@
     {!! Form::checkbox('is_sellable', 1, $character->is_sellable, ['class' => 'form-check-input', 'data-toggle' => 'toggle', 'id' => 'resellable']) !!}
     {!! Form::label('is_sellable', 'Is Resellable', ['class' => 'form-check-label ml-3']) !!}
 </div>
-<div class="card mb-3" id="resellOptions">
-    <div class="card-body">
-        {!! Form::label('Resale Value') !!} {!! add_help('This value is publicly displayed on the character\'s page.') !!}
-        {!! Form::text('sale_value', $character->sale_value, ['class' => 'form-control']) !!}
-    </div>
+<div class="form-group">
+    {!! Form::label('Resale Value') !!} {!! add_help('This value is publicly displayed on the character\'s page. It\'s hidden if zero or lower.') !!}
+    {!! Form::text('sale_value', $character->sale_value, ['class' => 'form-control']) !!}
 </div>
 <div class="form-group">
     {!! Form::label('On Transfer Cooldown Until (Optional)') !!}
@@ -66,27 +64,5 @@
             dateFormat: "yy-mm-dd",
             timeFormat: 'HH:mm:ss',
         });
-
-        //$('[data-toggle=toggle]').bootstrapToggle();
-
-        // Resell options /////////////////////////////////////////////////////////////////////////////
-
-        var $resellable = $('#resellable');
-        var $resellOptions = $('#resellOptions');
-
-        var resellable = $resellable.is(':checked');
-
-        updateOptions();
-
-        $resellable.on('change', function(e) {
-            resellable = $resellable.is(':checked');
-
-            updateOptions();
-        });
-
-        function updateOptions() {
-            if (resellable) $resellOptions.removeClass('hide');
-            else $resellOptions.addClass('hide');
-        }
     });
 </script>