edit classes frontend redesign #887
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 568. |
NIDHI2023
reviewed
Nov 17, 2024
There was a problem hiding this comment.
This is a really nice redesign! It looks so much more cleaner. I have a few suggestions you could add:
- When searching for a class that doesn't exist, maybe add some padding between the label thing and the end of the white part so it doesn't look too crammed together
- I think making the Go to Course buttons more visible by changing the color or adding a border or something else would be good. And also maybe adding more padding again to make the class cards look more vertically symmetric
rgu0114
requested changes
Dec 5, 2024
rgu0114
requested changes
Dec 5, 2024
rgu0114
requested changes
Dec 6, 2024
| roleString = 'PROF'; | ||
| let roleString = ""; | ||
| let roleColor = ""; | ||
| let selectedBackgroundColor = "#F5F5F5"; |
There was a problem hiding this comment.
oh can we put these in the associated .scss file?
| )} | ||
| </div> | ||
| ) : ( | ||
| <></> |
There was a problem hiding this comment.
nit: let's avoid empty components <></> and use && where we can, assuming that has the same behavior
| import * as React from "react"; | ||
| import { useHistory } from "react-router"; | ||
| import { Icon } from "semantic-ui-react"; | ||
| import { Grid } from "@material-ui/core"; | ||
|
|
There was a problem hiding this comment.
General: non prof/ta former classes still seem to have the hover effect (benji 2110) when idt they should
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update of edit classes page:
current design:
redesign:
Test Plan
Notes
Breaking Changes
None