Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grey holidays out and change add rides errors #548

Open
wants to merge 52 commits into
base: dka36/Holidays
Choose a base branch
from

Conversation

selenaliu1
Copy link
Contributor

@selenaliu1 selenaliu1 commented Nov 7, 2024

Summary

  • grey out holidays on the minical
  • move isHolidays to holidays.ts for reusability
  • for add rides, check if selected date is holiday, if it is, give corresponding error message
  • styling: error messages don't change the size of the modal
  • create more specific error messaging

Test Plan

Correct dates are now greyed out.

Screen.Recording.2024-11-06.at.6.39.54.PM.mov
Screenshot 2024-11-13 at 7 31 46 PM

Notes

need to check edit rides to see if people can edit rides to weekends/holidays.

Breaking Changes

Dwain-Anderson and others added 27 commits October 6, 2024 10:19
- Brought back old landing page
- Included wave svg
- Clickable TOS button and DTI logo
@selenaliu1 selenaliu1 requested a review from a team as a code owner November 7, 2024 00:08
@dti-github-bot
Copy link
Member

dti-github-bot commented Nov 7, 2024

[diff-counting] Significant lines: 2236. This diff might be too big! Developer leads are invited to review the code.

Atikpui007 and others added 21 commits November 6, 2024 19:19
Bumps [cookie](https://github.com/jshttp/cookie) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together.

Updates `cookie` from 0.6.0 to 0.7.1
- [Release notes](https://github.com/jshttp/cookie/releases)
- [Commits](jshttp/cookie@v0.6.0...v0.7.1)

Updates `express` from 4.21.0 to 4.21.1
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.1/History.md)
- [Commits](expressjs/express@4.21.0...4.21.1)

---
updated-dependencies:
- dependency-name: cookie
  dependency-type: indirect
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
…tend/multi-9f37c16f8f

Bump cookie and express in /frontend
Search and filter Custom Component
@selenaliu1 selenaliu1 changed the title Grey holidays out on minical Grey holidays out Nov 14, 2024
@selenaliu1 selenaliu1 changed the title Grey holidays out Grey holidays out and change add rides errors Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants