Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vine: Fix cache directory property of manager in Python bindings #3966

Conversation

tphung3
Copy link
Contributor

@tphung3 tphung3 commented Oct 31, 2024

Proposed Changes

The cache directory of the TaskVine manager is incorrectly assigned to each workflow's staging directory. The property now correctly points to the global cache of TaskVine which is workflow-agnostic.

Merge Checklist

The following items must be completed before PRs can be merge.
Check these off to verify you have completed all steps.

  • make test Run local tests prior to pushing.
  • make format Format source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)
  • make lint Run lint on source code prior to pushing.
  • Manual Update Update the manual to reflect user-visible changes.
  • Type Labels Select a github label for the type: bugfix, enhancement, etc.
  • Product Labels Select a github label for the product: TaskVine, Makeflow, etc.
  • PR RTM Mark your PR as ready to merge.

@btovar btovar self-requested a review November 1, 2024 14:57
@btovar btovar merged commit a9785ef into cooperative-computing-lab:master Nov 1, 2024
10 checks passed
btovar pushed a commit that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants