Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Trigger.dev #3717

Open
wants to merge 9 commits into
base: next
Choose a base branch
from
Open

Fix: Trigger.dev #3717

wants to merge 9 commits into from

Conversation

rennokki
Copy link
Contributor

@rennokki rennokki commented Oct 4, 2024

Changes

Fixed the Trigger.dev images pointing to the latest instead of main.

latest tag is 8 months old and points to v2 while main is the newest, v3.

This will also fix problems with ARM machines not being able to run because latest is v2 and has no support for linux/arm64

Trigger also comes with new services: Redis and Electric, which are configured in their own Docker examples.

Issues

N/A

@rennokki rennokki marked this pull request as draft October 4, 2024 09:47
@rennokki rennokki marked this pull request as ready for review October 5, 2024 07:21
@rennokki
Copy link
Contributor Author

rennokki commented Oct 5, 2024

@andrasbacsai

The trigger stack needed new services: electric and redis.

The trigger with external database service is expected to be handled by the user, but I'm not sure if we should remove it, as the stack is complete in trigger.yaml.

@Mortalife
Copy link

This will likely not run in Staging or Production because you're missing both the coordinator service and the docker-provider. The versions for these images should be v3 not main as has been set.

There are more complete versions (though still not following the deployment best practices provided by Trigger.dev) available in the discussion on this topic.

You can find details of official deployment which myself and other have based our working examples off at: https://github.com/triggerdotdev/docker

You can find the discussion at: #2439

@rennokki
Copy link
Contributor Author

rennokki commented Oct 6, 2024

@Mortalife Let me take a look at it closer and I'll join that discussion afterwards.

@andrasbacsai
Copy link
Member

I think this is still WIP, right? As we need the coorditor (and probably other stuffs) as well.

@andrasbacsai andrasbacsai added the 💤 Waiting for feedback Issues awaiting a response from the author. label Oct 7, 2024
@rennokki rennokki marked this pull request as draft October 8, 2024 05:24
@rennokki
Copy link
Contributor Author

rennokki commented Oct 8, 2024

@andrasbacsai Looking at it in the next hours.

@peaklabs-dev peaklabs-dev removed the 💤 Waiting for feedback Issues awaiting a response from the author. label Oct 8, 2024
@peaklabs-dev peaklabs-dev added the ⚙️ Service Issues requesting or PRs adding/fixing service templates. label Oct 9, 2024
@rennokki rennokki marked this pull request as ready for review October 12, 2024 08:20
@rennokki
Copy link
Contributor Author

Not sure if I am the only one that has issues with shared configurations. They seem to not be working properly? I end up in the SERVICE_* variables not working well and get populated in my env variables.

Copy link

gitguardian bot commented Oct 12, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14127286 Triggered Generic Password cda2e26 lang/ro.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@hamedyosefian
Copy link
Contributor

Hi... when release this version ??

@peaklabs-dev
Copy link
Member

peaklabs-dev commented Oct 17, 2024

@rennokki I have tested it and have one improvement request. Could you please check the healthcheck for Trigger as I am unsure if it has one and the current one is not working.

@peaklabs-dev peaklabs-dev added the 💤 Waiting for feedback Issues awaiting a response from the author. label Oct 17, 2024
@rennokki
Copy link
Contributor Author

@peaklabs-dev peaklabs-dev removed the 💤 Waiting for feedback Issues awaiting a response from the author. label Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Service Issues requesting or PRs adding/fixing service templates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants