eps_error_tracking - adding error tracking for epsilon analytics

conversant · Jan 5, 2023 · 08cc7af · 08cc7af
1 parent 1755a22
commit 08cc7af
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/modules/conversantAnalyticsAdapter.js b/modules/conversantAnalyticsAdapter.js
@@ -158,7 +158,7 @@ function onBidderError(args) {
   let bidRequest = args.bidderRequest;
   let auctionId = bidRequest.auctionId;
   let bidderCode = bidRequest.bidderCode;
-  logWarn('onBidderError(): error received from bidder ' + bidderCode + '. Status = ' + error.status + ', Message = ' + error.statusText);
+  logWarn(CNVR_CONSTANTS.LOG_PREFIX + 'onBidderError(): error received from bidder ' + bidderCode + '. Status = ' + error.status + ', Message = ' + error.statusText);
   let errorObj = {
     status: error.status,
     message: error.statusText,
@@ -584,7 +584,7 @@ cnvrHelper.getPageUrl = function() {
  */
 cnvrHelper.sendErrorData = function(eventType, exception) {
   if (!cnvrHelper.doSendErrorData) {
-    logWarn('Skipping sending error data due to config disabling error logging, error thrown = ' + exception);
+    logWarn(CNVR_CONSTANTS.LOG_PREFIX + 'Skipping sending error data due to config disabling error logging, error thrown = ' + exception);
     return;
   }
 
@@ -644,8 +644,8 @@ conversantAnalytics.enableAnalytics = function (config) {
   // Math.random() pseudo-random number in the range 0 to less than 1 (inclusive of 0, but not 1)
   cnvrHelper.doSample = Math.random() < initOptions.cnvr_sample_rate;
 
-  if (initOptions.send_error_data !== undefined && initOptions.send_error_data !== null && typeof initOptions.send_error_data === 'boolean') {
-    cnvrHelper.doSendErrorData = initOptions.send_error_data;
+  if (initOptions.send_error_data !== undefined && initOptions.send_error_data !== null) {
+    cnvrHelper.doSendErrorData = !!initOptions.send_error_data; //Forces data into boolean type
   }
 
   conversantAnalyticsEnabled = true;

diff --git a/test/spec/modules/conversantAnalyticsAdapter_spec.js b/test/spec/modules/conversantAnalyticsAdapter_spec.js
@@ -70,7 +70,6 @@ describe('Conversant analytics adapter tests', function() {
       conversantAnalytics.disableAnalytics();
       conversantAnalytics.enableAnalytics();
       expect(utils.logError.calledWith(CNVR_CONSTANTS.LOG_PREFIX + 'siteId is required.')).to.be.true;
-      conversantAnalytics.disableAnalytics();
     });
 
     it('should not log error if valid config is passed', function() {
@@ -89,15 +88,13 @@ describe('Conversant analytics adapter tests', function() {
           CNVR_CONSTANTS.LOG_PREFIX + 'Global sample rate set to 1'
         )
       ).to.be.true;
-      conversantAnalytics.disableAnalytics();
     });
 
     it('should sample when sampling set to 1', function() {
       sandbox.stub(utils, 'logError');
       conversantAnalytics.enableAnalytics(VALID_ALWAYS_SAMPLE_CONFIG);
       expect(utils.logError.called).to.equal(false);
       expect(cnvrHelper.doSample).to.equal(true);
-      conversantAnalytics.disableAnalytics();
     });
 
     it('should NOT sample when sampling set to 0', function() {
@@ -108,7 +105,6 @@ describe('Conversant analytics adapter tests', function() {
       conversantAnalytics.enableAnalytics(NEVER_SAMPLE_CONFIG);
       expect(utils.logError.called).to.equal(false);
       expect(cnvrHelper.doSample).to.equal(false);
-      conversantAnalytics.disableAnalytics();
     });
   });
 
@@ -203,8 +199,6 @@ describe('Conversant analytics adapter tests', function() {
         },
         adUnits: {}
       });
-
-      conversantAnalytics.disableAnalytics();
     });
 
     it('keyExistsAndIsObject() should return correct data', function() {