Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backtab pty.output generation #1686

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Fix backtab pty.output generation #1686

merged 1 commit into from
Dec 30, 2024

Conversation

Yaraslaut
Copy link
Member

Closes #1685
Solution is somewhat ugly, I am open for better one @christianparpart :)
but we need to preserve behavior for sending it as a key for #1578

@github-actions github-actions bot added the VT: Backend Virtual Terminal Backend (libterminal API) label Dec 30, 2024
@Yaraslaut Yaraslaut force-pushed the fix/backtab_handling branch from 6c1f823 to a452a5f Compare December 30, 2024 10:10
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think the comment above isn't really adding anything :)

src/vtbackend/InputGenerator.cpp Outdated Show resolved Hide resolved
@Yaraslaut Yaraslaut force-pushed the fix/backtab_handling branch from a452a5f to 381d472 Compare December 30, 2024 11:51
@Yaraslaut Yaraslaut enabled auto-merge December 30, 2024 11:52
@Yaraslaut Yaraslaut merged commit e4992cf into master Dec 30, 2024
30 checks passed
@Yaraslaut Yaraslaut deleted the fix/backtab_handling branch December 30, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VT: Backend Virtual Terminal Backend (libterminal API)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shift+Tab no longer works
2 participants