Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce boxed types for margins and handling of input #1491

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Introduce boxed types for margins and handling of input #1491

merged 1 commit into from
Mar 27, 2024

Conversation

Yaraslaut
Copy link
Member

Add boxed types for window margins and input handling

@github-actions github-actions bot added VT: Backend Virtual Terminal Backend (libterminal API) frontend Contour Terminal Emulator (GUI frontend) test Unit tests labels Mar 26, 2024
@Yaraslaut Yaraslaut force-pushed the improvement/some_boxing branch from 25d1f1d to 0353420 Compare March 27, 2024 15:43
@Yaraslaut Yaraslaut force-pushed the improvement/some_boxing branch from 0353420 to e0ad300 Compare March 27, 2024 15:47
christianparpart
christianparpart approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For horizontal and vertical margins I totally agree and understand. For Handled it took me a while to see the benefit. I think there actually is one, because we encode the meaning of that boolean. So 👍 :)

@christianparpart christianparpart added the no changelog Tells the CI to not require a changelog entry label Mar 27, 2024
@Yaraslaut
Copy link
Member Author

For horizontal and vertical margins I totally agree and understand. For Handled it took me a while to see the benefit. I think there actually is one, because we encode the meaning of that boolean. So 👍 :)

Concerning Handled, yes, i added it to see the meaning of the bool value, since it is not obvious what this bool means when returned from one function into another

@christianparpart christianparpart merged commit b341b44 into master Mar 27, 2024
55 of 57 checks passed
@christianparpart christianparpart deleted the improvement/some_boxing branch March 27, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianparpart christianparpart christianparpart approved these changes

Assignees
No one assigned
Labels
frontend Contour Terminal Emulator (GUI frontend) no changelog Tells the CI to not require a changelog entry test Unit tests VT: Backend Virtual Terminal Backend (libterminal API)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yaraslaut @christianparpart