Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of config generation #1483

Merged
merged 1 commit into from
Mar 15, 2024

Small fixed for config generation

95b2a9b
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Update of config generation #1483

Small fixed for config generation
95b2a9b
Select commit
Loading
Failed to load commit list.
GitHub Actions / clang-tidy-review completed Mar 11, 2024 in 0s

clang-tidy-review

There were 3 warnings

Details

src/contour/Actions.h:264: warning: invalid case style for constant 'WriteScreenAction' [readability-identifier-naming]
src/contour/Config.h:1004: warning: method 'format' can be made static [readability-convert-member-functions-to-static]
src/contour/Config.h:1006: warning: parameter name 'v' is too short, expected at least 3 characters [readability-identifier-length]

Annotations

Check warning on line 265 in src/contour/Actions.h

See this annotation in the file changed.

@github-actions github-actions / clang-tidy-review

clang-tidy

warning: invalid case style for constant 'WriteScreenAction' [readability-identifier-naming]

```suggestion
            const auto writeScreenAction = std::get<contour::actions::WriteScreen>(_action);
            name = fmt::format("{} chars: '{}'", writeScreenAction, writeScreenAction.chars);
```

Check warning on line 1004 in src/contour/Config.h

See this annotation in the file changed.

@github-actions github-actions / clang-tidy-review

clang-tidy

warning: method 'format' can be made static [readability-convert-member-functions-to-static]

```suggestion
gs);static 
```

Check warning on line 1006 in src/contour/Config.h

See this annotation in the file changed.

@github-actions github-actions / clang-tidy-review

clang-tidy

warning: parameter name 'v' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
t& v)
   ^
```