Merge pull request #1679 from contour-terminal/improvement/warn-on-xd…

…g-fs-rror [contour] Do not abort when failing to create `XDG_STATE_HOME/contour/crash` directory
contour-terminal · Dec 27, 2024 · a6b9d40 · a6b9d40
2 parents e2e76af + e76bcb6
commit a6b9d40
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/metainfo.xml b/metainfo.xml
@@ -107,7 +107,7 @@
     <release version="0.6.1" urgency="medium" type="development">
       <description>
         <ul>
-          <li> ... </li>
+          <li>Do not abort when failing to create `XDG_STATE_HOME/contour/crash` directory</li>
         </ul>
       </description>
     </release>

diff --git a/src/contour/ContourApp.cpp b/src/contour/ContourApp.cpp
@@ -132,8 +132,13 @@ ContourApp::ContourApp(): app("contour", "Contour Terminal Emulator", CONTOUR_VE
 
 #if defined(__linux__)
     auto crashLogDirPath = crispy::app::instance()->localStateDir() / "crash";
-    std::filesystem::create_directories(crashLogDirPath);
     crashLogDir = crashLogDirPath.string();
+    auto errorCode = std::error_code {};
+    std::filesystem::create_directories(crashLogDirPath, errorCode);
+    if (errorCode)
+        std::cerr << std::format("Warning: Failed to create crash log directory: {} ({})\n",
+                                 errorCode.message(),
+                                 errorCode.category().name());
     // signal(SIGSEGV, segvHandler);
     signal(SIGABRT, segvHandler);
 #endif