Skip to content

Commit

Permalink
Merge pull request #1675 from contour-terminal/release
Browse files Browse the repository at this point in the history
Prepare release 0.6.0
  • Loading branch information
christianparpart authored Dec 26, 2024
2 parents 96a01b6 + c8231f0 commit 6d1f087
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 5 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,7 @@ jobs:
# cmake --build build --target package-verbose
# ls -hl build/
# find build/src/contour/contour.app -print
BASENAME="contour-${{ steps.set_vars.outputs.version }}-macOS-x86
BASENAME="contour-${{ steps.set_vars.outputs.version }}-macOS-x86"
mv -vf "build/Contour-${{ steps.set_vars.outputs.VERSION_STRING }}-Darwin.dmg" "${BASENAME}.dmg"
- name: upload to artifact store (DMG)
uses: actions/upload-artifact@v4
Expand Down Expand Up @@ -1238,10 +1238,8 @@ jobs:
files: |
*.deb
*.ddeb
*.rpm
*.dmg
*.msi
*.zst
*.zip
*.AppImage
# }}}
2 changes: 1 addition & 1 deletion metainfo.xml
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@
-->

<release version="0.5.2" urgency="medium" type="development">
<release version="0.6.0" urgency="medium" date="2024-12-26">
<description>
<ul>
<li>Fixes search editor preservation bug on exit from search mode</li>
Expand Down
23 changes: 23 additions & 0 deletions src/contour/Config.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2131,7 +2131,30 @@ std::string createForProfile(Config const& c)
doc.append(writer.process(writer.whichDoc(v), name, v.value()));
};

// Something is wrong for vtpty::Process::ExecInfo formating for static build
// we add this lambda to handle it in overload set for now
auto const processConfigEntryWithExecInfo =
[&]<documentation::StringLiteral ConfigDoc, documentation::StringLiteral WebDoc>(
auto name,
contour::config::ConfigEntry<
vtpty::Process::ExecInfo,
contour::config::documentation::DocumentationEntry<ConfigDoc, WebDoc>> const& vEntry) {
auto v = vEntry.value();
auto args = std::string { "[" };
args.append(v.arguments | ::ranges::views::join(", ") | ::ranges::to<std::string>);
args.append("]");

doc.append(writer.process(writer.whichDoc(vEntry), name, v.program, args, [&]() -> std::string {
auto fromConfig = v.workingDirectory.string();
if (fromConfig.empty()
|| fromConfig == crispy::homeResolvedPath("~", vtpty::Process::homeDirectory()))
return std::string { "\"~\"" };
return fromConfig;
}()));
};

auto completeOverload = crispy::overloaded {
processConfigEntryWithExecInfo,
processConfigEntry,
[&]([[maybe_unused]] auto name, [[maybe_unused]] auto const& v) {},
};
Expand Down
2 changes: 1 addition & 1 deletion src/contour/Config.h
Original file line number Diff line number Diff line change
Expand Up @@ -1131,7 +1131,7 @@ struct Writer
return format(doc, v.count());
}

[[nodiscard]] std::string format(std::string_view doc, vtpty::Process::ExecInfo const& v)
[[nodiscard]] std::string format(std::string_view doc, vtpty::Process::ExecInfo v)
{
auto args = std::string { "[" };
args.append(v.arguments | ranges::views::join(", ") | ranges::to<std::string>);
Expand Down

0 comments on commit 6d1f087

Please sign in to comment.