Adapt to latest libunicode, making use of new grapheme_line_segmenter API #4420
Triggered via pull request
April 21, 2024 18:25
christianparpart
christianparpart
synchronize
#1486
Status
Success
Total duration
13s
Artifacts
–
Annotations
11 warnings
|
triage
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/labeler@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
clang-tidy:
src/vtbackend/Line.cpp#L164
warning: member 'input' of type 'const TrivialLineBuffer &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members]
```cpp
TrivialLineBuffer const& input;
^
```
|
|
clang-tidy:
src/vtbackend/Line.cpp#L164
warning: member variable 'input' has public visibility [misc-non-private-member-variables-in-classes]
```cpp
TrivialLineBuffer const& input;
^
```
|
|
clang-tidy:
src/vtbackend/Line.cpp#L165
warning: member variable 'columns' has public visibility [misc-non-private-member-variables-in-classes]
```cpp
InflatedLineBuffer<Cell> columns;
^
```
|
|
clang-tidy:
src/vtbackend/Line.cpp#L174
warning: implicit conversion 'const char *' -> bool [readability-implicit-bool-conversion]
```suggestion
vtParserLog()("Inflating TrivialLineBuffer: '{}'", input.text.data() != nullptr ? crispy::escape(input.text.data()) : "");
```
|
|
clang-tidy:
src/vtbackend/Line.cpp#L192
warning: an exception may be thrown in function 'on_invalid' which should not throw exceptions [bugprone-exception-escape]
```cpp
void on_invalid(std::string_view /*invalid*/) noexcept
^
```
|
|
clang-tidy:
src/vtbackend/Line.cpp#L202
warning: an exception may be thrown in function 'on_ascii' which should not throw exceptions [bugprone-exception-escape]
```cpp
void on_ascii(std::string_view text) noexcept
^
```
|
|
clang-tidy:
src/vtbackend/Line.cpp#L205
warning: variable name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
for (auto const ch: text)
^
```
|
|
clang-tidy:
src/vtbackend/Line.cpp#L213
warning: an exception may be thrown in function 'on_grapheme_cluster' which should not throw exceptions [bugprone-exception-escape]
```cpp
void on_grapheme_cluster(std::string_view text, unsigned width) noexcept
^
```
|
|
clang-tidy:
src/vtbackend/Line.cpp#L221
warning: variable name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
for (auto const ch: text)
^
```
|
|
clang-tidy:
src/vtbackend/Line.cpp#L223
warning: variable name 'r' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
unicode::ConvertResult const r = unicode::from_utf8(utf8DecoderState, static_cast<uint8_t>(ch));
^
```
|