Skip to content

Small refactor to generalize config creation #4410

Small refactor to generalize config creation

Small refactor to generalize config creation #4410

Triggered via pull request April 6, 2024 06:56
@YaraslautYaraslaut
synchronize #1493
Status Success
Total duration 13s
Artifacts

labeler.yml

on: pull_request_target
Fit to window
Zoom out
Zoom in

Annotations

11 warnings
triage
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/labeler@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
clang-tidy: src/contour/Config.cpp#L184
warning: parameter name 'c' is too short, expected at least 3 characters [readability-identifier-length] ```cpp std::string createString(Config const& c) ^ ```
clang-tidy: src/contour/Config.cpp#L1836
warning: parameter name 'c' is too short, expected at least 3 characters [readability-identifier-length] ```cpp std::string createString(Config const& c) ^ ```
clang-tidy: src/contour/Config.cpp#L1901
warning: variable name '_' is too short, expected at least 3 characters [readability-identifier-length] ```cpp const auto _ = typename Writer::Offset {}; ^ ```
clang-tidy: src/contour/Config.cpp#L2169
warning: variable name '_' is too short, expected at least 3 characters [readability-identifier-length] ```cpp const auto _ = typename Writer::Offset {}; ^ ```
clang-tidy: src/contour/Config.h#L890
warning: class 'Writer' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions] ```cpp ct Writer ^ ```
clang-tidy: src/contour/Config.h#L922
warning: parameter name 'c' is too short, expected at least 3 characters [readability-identifier-length] ```cpp st& c, T) ^ ```
clang-tidy: src/contour/Config.h#L922
warning: all parameters should be named in a function [readability-named-parameter] ```suggestion st& c, T /*unused*/) ```
clang-tidy: src/contour/Config.h#L938
warning: the parameter 'doc' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param] ```cpp doc, T val) ^ ```
clang-tidy: src/contour/Config.h#L939
warning: performing an implicit widening conversion to type 'size_t' (aka 'unsigned long') of a multiplication performed in type 'int' [bugprone-implicit-widening-of-multiplication-result] ```cpp val) ^ ``` <details> <summary>Additional context</summary> **src/contour/Config.h:938:** make conversion explicit to silence this warning ```cpp val) ^ ``` **src/contour/Config.h:938:** perform multiplication in a wider type ```cpp val) ^ ``` </details>
clang-tidy: src/contour/Config.h#L943
warning: the parameter 'doc' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param] ```cpp ename... T> ^ ```