fix: JSON schema issue with gemini tool calls #3851
+87
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for continuedev canceled.
|
RomneyDa
requested changes
Jan 28, 2025
| await new Promise(resolve => setTimeout(resolve, 100)); | ||
| } else if (part.type === 'tool') { | ||
| // Add delay before tool response to ensure tool call was processed | ||
| await new Promise(resolve => setTimeout(resolve, 100)); |
There was a problem hiding this comment.
@monotykamary this is great! The schema cleaning is a needed thing I failed to add.
Could you remove the 100ms awaits or explain the thought process there beyond the comments?
There's a good chance it could take much longer than 100ms to process a tool call, and I think in the future continue GUI should handle any needed waiting/ordering. Did you find this necessary to work? Also for another edge case I think for now it's reasonable to assume that there will never be function calls and responses within the same message, and if there were, same reasoning could apply. Any other thoughts on your approach?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes tool calling error that happens when using Gemini. Not actually sure if it's because of MCP servers, but at least now it works.
Checklist
Screenshots
Testing instructions
Select any Gemini model and enable tools. Prompt it in such a way that it will invoke the tool and see the results.