Use ephemeral browser for the OpenID popup #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will not share the browser state inside the OpenID popup with the regular Safari instance. It has the downside that the user has to re-login even if they are already logged in to Contentpass in the regular browser. But it has the big benefit that we get rid of the confirmation dialog before the OpenID popup.
slawomirzaba
previously approved these changes
May 17, 2024
slawomirzaba
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will not share the browser state inside the OpenID popup with the
regular Safari instance. It has the downside that the user has to
re-login even if they are already logged in to Contentpass in the
regular browser. But it has the big benefit that we get rid of the
confirmation dialog before the OpenID popup.