Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(get-string-match): trim strings #2927

Closed
wants to merge 2 commits into from
Closed

fix(get-string-match): trim strings #2927

wants to merge 2 commits into from

Conversation

denkristoffer
Copy link
Collaborator

Purpose of PR

There's a case where getStringMatch returns no matches

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 1, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 9f4aede

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@contentful/f36-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Nov 5, 2024 8:05am

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 112.07 KB (+0.04% 🔺) 2.3 s (+0.04% 🔺) 1.8 s (+16.19% 🔺) 4 s
Module 110.69 KB (-0.14% 🔽) 2.3 s (-0.14% 🔽) 1.4 s (-8.69% 🔽) 3.6 s

@denkristoffer denkristoffer marked this pull request as ready for review November 5, 2024 07:59
@denkristoffer denkristoffer requested review from damann and a team as code owners November 5, 2024 07:59
@denkristoffer
Copy link
Collaborator Author

Handled in #2928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damann damann Awaiting requested review from damann damann is a code owner

@miguelcrespo miguelcrespo Awaiting requested review from miguelcrespo miguelcrespo is a code owner automatically assigned from contentful/team-isotopes

@andipaetzold andipaetzold Awaiting requested review from andipaetzold

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@denkristoffer