Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(progress-stepper): add horizontal width limitation example #2925

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

whitelisab
Copy link
Contributor

@whitelisab whitelisab commented Oct 29, 2024

Purpose of PR

This PR adds to the website documentation for the ProgressStepper component by adding an example explaining the extra width that appears on the component when rendered in the horizontal orientation. We added a new example with borders to visually demonstrate this, as well as an explanation.

Screenshot of changes to the website:

Screenshot 2024-10-29 at 4 22 10 PM

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

Copy link

changeset-bot bot commented Oct 29, 2024

⚠️ No Changeset found

Latest commit: a383562

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Oct 29, 2024 10:28pm

Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 112.03 KB (0%) 2.3 s (0%) 1.5 s (+23.4% 🔺) 3.7 s
Module 110.84 KB (0%) 2.3 s (0%) 1.7 s (+3.66% 🔺) 3.9 s

@whitelisab whitelisab merged commit 8beee9e into main Oct 31, 2024
12 checks passed
@whitelisab whitelisab deleted the feat/progress-stepper-horizontal-width branch October 31, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants