Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ToggleButton): story controls #2793

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(ToggleButton): story controls #2793

wants to merge 2 commits into from

Conversation

cf-remylenoir
Copy link
Collaborator

Purpose of PR

Fixes the ToggleButton component story controls.

Screen.Recording.2024-06-11.at.14.02.17.mov

@vercel Vercel
Copy link

vercel bot commented Jun 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Jun 11, 2024 0:10am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: facf1db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cf-remylenoir cf-remylenoir changed the title fix(ToggleButton): story controls chore(ToggleButton): story controls Jun 11, 2024
@cf-remylenoir cf-remylenoir marked this pull request as ready for review June 11, 2024 12:05
@cf-remylenoir cf-remylenoir requested review from damann and a team as code owners June 11, 2024 12:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 135.59 KB (0%) 2.8 s (0%) 113 ms (+53.25% 🔺) 2.9 s
Module 131.92 KB (0%) 2.7 s (0%) 139 ms (+86.08% 🔺) 2.8 s

damann
damann approved these changes Jun 11, 2024
View reviewed changes
Copy link

@damann damann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton for the quick fix! 🏃‍➡️

@github-actions GitHub Actions
Copy link

Marking pull request as stale since there was no activity for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damann damann damann approved these changes

@massao massao massao approved these changes

@giotiskl giotiskl Awaiting requested review from giotiskl giotiskl is a code owner automatically assigned from contentful/team-isotopes

Assignees
No one assigned
Labels
stale Used to mark when there was no activity for a set period of time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cf-remylenoir @massao @damann