Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix missing peerDependency warnings #2587

Merged
merged 2 commits into from
Oct 10, 2023
Merged

fix: fix missing peerDependency warnings #2587

merged 2 commits into from
Oct 10, 2023

Conversation

wojtekmaj
Copy link
Contributor

@wojtekmaj wojtekmaj commented Oct 10, 2023

Purpose of PR

Because the packages in question rely on @contentful/f36-core (and in one case, react-popper), which has react-dom in its peerDependencies, these packages need to have react-dom in their peerDependencies as well.

Fixes #2586

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

Because the packages in question rely on @contentful/f36-core (and in one case, react-popper), which has react-dom in its peerDependencies, these packages need to have react-dom in its peerDependencies as well.

Fixes #2586
@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2023

🦋 Changeset detected

Latest commit: 679ac2c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
@contentful/f36-icon Patch
@contentful/f36-list Patch
@contentful/f36-multiselect Patch
@contentful/f36-pagination Patch
@contentful/f36-popover Patch
@contentful/f36-spinner Patch
@contentful/f36-text-link Patch
@contentful/f36-typography Patch
@contentful/f36-accordion Patch
@contentful/f36-asset Patch
@contentful/f36-autocomplete Patch
@contentful/f36-badge Patch
@contentful/f36-button Patch
@contentful/f36-card Patch
@contentful/f36-collapse Patch
@contentful/f36-copybutton Patch
@contentful/f36-core Patch
@contentful/f36-datetime Patch
@contentful/f36-datepicker Patch
@contentful/f36-drag-handle Patch
@contentful/f36-entity-list Patch
@contentful/f36-empty-state Patch
@contentful/f36-forms Patch
@contentful/f36-menu Patch
@contentful/f36-modal Patch
@contentful/f36-note Patch
@contentful/f36-notification Patch
@contentful/f36-pill Patch
@contentful/f36-skeleton Patch
@contentful/f36-table Patch
@contentful/f36-tabs Patch
@contentful/f36-tooltip Patch
@contentful/f36-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 10, 2023

@wojtekmaj is attempting to deploy a commit to the Contentful Apps Team on Vercel.

A member of the Team first needs to authorize it.

@wojtekmaj
Copy link
Contributor Author

Sorry, I was not able to generate changeset as documented:

wmaj@MacBook-Air forma-36 % npx changeset    
npm ERR! could not determine executable to run

npm ERR! A complete log of this run can be found in: /Users/wmaj/.npm/_logs/2023-10-10T11_00_10_496Z-debug-0.log

Copy link
Collaborator

@denkristoffer denkristoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The changeset binary has to be installed from @changesets/cli, I will get the docs updated. Thanks for pointing it out.

@vercel
Copy link

vercel bot commented Oct 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Oct 10, 2023 11:47am

@denkristoffer denkristoffer merged commit aff991c into contentful:main Oct 10, 2023
6 of 8 checks passed
@denkristoffer
Copy link
Collaborator

@all-contributors please add @wojtekmaj for bug, code

@allcontributors
Copy link
Contributor

@denkristoffer

I've put up a pull request to add @wojtekmaj! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug - Missing peerDependency warnings when installing packages using Yarn (modern)
2 participants