-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix missing peerDependency warnings #2587
fix: fix missing peerDependency warnings #2587
Conversation
Because the packages in question rely on @contentful/f36-core (and in one case, react-popper), which has react-dom in its peerDependencies, these packages need to have react-dom in its peerDependencies as well. Fixes #2586
🦋 Changeset detectedLatest commit: 679ac2c The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@wojtekmaj is attempting to deploy a commit to the Contentful Apps Team on Vercel. A member of the Team first needs to authorize it. |
Sorry, I was not able to generate changeset as documented:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The changeset binary has to be installed from @changesets/cli
, I will get the docs updated. Thanks for pointing it out.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@all-contributors please add @wojtekmaj for bug, code |
I've put up a pull request to add @wojtekmaj! 🎉 |
Purpose of PR
Because the packages in question rely on
@contentful/f36-core
(and in one case,react-popper
), which hasreact-dom
in itspeerDependencies
, these packages need to havereact-dom
in theirpeerDependencies
as well.Fixes #2586
PR Checklist
readme.md
file(s)