Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(forms): update accessibility guidelines for inputs #2561

Merged
merged 9 commits into from
Aug 24, 2023

Conversation

Lelith
Copy link
Collaborator

@Lelith Lelith commented Aug 16, 2023

Purpose of PR

This is an update for the documentation to further improve the accessibility guidelines and how to leverage FormControl for semantic validation and error states.

Updated guidelines for following components:

  • Checkbox and Checkbox.Group
  • Radio and Radio.Group
  • Select
  • Textarea

@Lelith Lelith requested a review from a team as a code owner August 16, 2023 15:18
@Lelith Lelith requested review from massao and giotiskl August 16, 2023 15:18
@vercel
Copy link

vercel bot commented Aug 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Aug 24, 2023 9:36am

@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2023

⚠️ No Changeset found

Latest commit: def7a5b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link

github-actions bot commented Aug 16, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 129.38 KB (0%) 2.6 s (0%) 306 ms (+29.27% 🔺) 2.9 s
Module 125.85 KB (0%) 2.6 s (0%) 259 ms (+7.58% 🔺) 2.8 s

package-lock.json Outdated Show resolved Hide resolved
Comment on lines +113 to +121
## Props (API reference)

### Select

<PropsTable of="Select" />

### Select Option

<PropsTable of="Option" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️‍🔥

Copy link
Collaborator

@cf-remylenoir cf-remylenoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, great additions 👌

@cf-remylenoir cf-remylenoir changed the title Update Accessibility Guidelines for Form Inputs chore(forms): update accessibility guidelines for inputs Aug 17, 2023
@Lelith Lelith enabled auto-merge (squash) August 21, 2023 10:59
@Lelith Lelith force-pushed the chore/F36-954_checkbox_documentation branch from 3c9fb15 to def7a5b Compare August 24, 2023 09:31
@Lelith Lelith disabled auto-merge August 24, 2023 09:45
@Lelith Lelith merged commit 6daf49b into main Aug 24, 2023
3 checks passed
@Lelith Lelith deleted the chore/F36-954_checkbox_documentation branch August 24, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants