Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tooltip support for avatar and avatar group components [] #2549

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

ronaldronson
Copy link
Contributor

Purpose of PR

Add tooltip support for the Avatar and AvatarGroup components.

Renders the tooltip when configured:
Screenshot 2023-07-26 at 12 14 36

Does not render the tooltip inside the dropdown for the AvatarGroup component:
Screenshot 2023-07-26 at 12 14 22

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

@ronaldronson ronaldronson requested review from a team and Lelith as code owners July 26, 2023 13:02
@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2023

⚠️ No Changeset found

Latest commit: 38d20e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jul 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Jul 26, 2023 1:26pm

@github-actions
Copy link

github-actions bot commented Jul 26, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 129.42 KB (0%) 2.6 s (0%) 74 ms (+130.74% 🔺) 2.7 s
Module 125.88 KB (0%) 2.6 s (0%) 60 ms (-4.74% 🔽) 2.6 s

Copy link
Collaborator

@Lelith Lelith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Lelith Lelith merged commit 91c9bab into main Jul 27, 2023
3 checks passed
@Lelith Lelith deleted the feat/add-tooltip-support-for-avatars-component branch July 27, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants