Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add function endpoints [EXT-5995] #2513

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

feat: add function endpoints [EXT-5995] #2513

wants to merge 11 commits into from

Conversation

michaelpineirocontentful
Copy link

@michaelpineirocontentful michaelpineirocontentful commented Jan 16, 2025 •
edited
Loading

Summary

Add function endpoints to be used through plain client

  • Updated plain-client.ts to include new function operations: get, getMany, getManyForEnvironment
  • Created function.ts
  • Enhanced common-types to support new function operations
  • Updated REST/endpoints/function.ts to handle new function endpoints

Motivation and Context

We want to have access to basic Functions API's through CMA.

Checklist (check all before merging)

  • Both unit and integration tests are passing
  • There are no breaking changes
  • Changes are reflected in the documentation

When adding a new method:

  • The new method is exported through the default and plain CMA client
  • All new public types are exported from ./lib/export-types.ts
  • Added a unit test for the new method
  • Added an integration test for the new method note: integration/e2e lives in app-hosting-monitoring
  • The new method is added to the documentation

@michaelpineirocontentful
feat: add function support
b50a456 
- Updated plain-client.ts to include new function operations: get, getMany, getManyForEnvironment
- Created function.ts
- Enhanced common-types to support new function operations
- Updated REST/endpoints/function.ts to handle new function endpoints
@michaelpineirocontentful
fix: add missing dependency in common types
c1e0e73
@michaelpineirocontentful
fix: Prettier formatting
c8582f4
@michaelpineirocontentful
fix: prettier formatting, removed query params, stronger typing for f…
8d1e35e 
…unc. params.
@michaelpineirocontentful
fix: getMany integration test
a41ae22
@michaelpineirocontentful
fix: Added function interface, createFunctionApi, & some integration …
c909b1b 
…tests
@michaelpineirocontentful
Merge branch 'master' into add-functions
ddab3ce
@michaelpineirocontentful
fix: added documentation and adjusted test
d9a669f
@michaelpineirocontentful
Merge branch 'add-functions' of github.com:contentful/contentful-mana…
bc1e599 
…gement.js into add-functions
t-col
t-col reviewed Jan 17, 2025
View reviewed changes
lib/common-types.ts Outdated Show resolved Hide resolved
@michaelpineirocontentful michaelpineirocontentful changed the title feat: add function endpoints feat: add function endpoints [EXT-5995] Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-col t-col t-col left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelpineirocontentful @t-col