Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to eslint v9 #2486

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Migrate to eslint v9 #2486

merged 4 commits into from
Jan 23, 2025

Conversation

axe312ger
Copy link
Collaborator

@axe312ger axe312ger commented Nov 26, 2024 •
edited
Loading

Hey there, as part of the modernization for #2334, I updated eslint to v9.

This will be applied to SDK-CORE and CDA later on as well :)

  • Simplified config 🙏
  • We are pure TypeScript now -> got rid of all js related things 🗑️
  • There have been some errors, so I had to reconfigure some new rules to throw warnings so we can fix these later on 🚀
  • Only minimal changes to the actual plugin code have been necessary 💯
  • Prettier is also out of date, but I will wait with a PR for this till this is merged 👀

@axe312ger axe312ger requested a review from a team as a code owner November 26, 2024 12:55
@axe312ger axe312ger changed the title Migrarte eslint to v9 Migrate to eslint v9 Nov 26, 2024
@axe312ger axe312ger mentioned this pull request Nov 26, 2024
Open
11 tasks
mgoudy91
mgoudy91 previously approved these changes Nov 26, 2024
View reviewed changes
@mgoudy91 mgoudy91 force-pushed the build/modernize-eslint branch from c04f368 to aadd87f Compare December 3, 2024 23:30
@axe312ger axe312ger force-pushed the build/modernize-eslint branch 2 times, most recently from f3ecde5 to 05d825b Compare January 8, 2025 16:16
@mgoudy91 mgoudy91 force-pushed the build/modernize-eslint branch from 05d825b to 246dbf0 Compare January 22, 2025 22:25
@mgoudy91 mgoudy91 force-pushed the build/modernize-eslint branch from 246dbf0 to 9c90e06 Compare January 23, 2025 00:03
@mgoudy91 mgoudy91 merged commit 5100ad6 into master Jan 23, 2025
7 checks passed
@mgoudy91 mgoudy91 deleted the build/modernize-eslint branch January 23, 2025 02:15
@contentful-automation
Copy link
Contributor

🎉 This PR is included in version 11.43.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

mgoudy91 pushed a commit that referenced this pull request Jan 27, 2025
@axe312ger @mgoudy91
Migrate to eslint v9 (#2486)
eebbeb7 
* build: migrate to eslint v9 and clean it up

* style: manual fixes to make new eslint happy

* style: apply eslint autofix

* build: downgrade to TypeScript 5.6 to ensure compatability with typedoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoudy91 mgoudy91 mgoudy91 approved these changes

Assignees
No one assigned
Labels
awaiting feedback released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axe312ger @mgoudy91