build: dependency update that passes all tests #2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Bumps [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) from 4.17.4 to 4.17.5. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash) --- updated-dependencies: - dependency-name: "@types/lodash" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
marcolink
previously approved these changes
Jun 27, 2024
I think its a combo:
But its crazy that it doubles the size! |
|
Or, just a guess, but could also be because of dependency duplication and the current bundle in a bundle situation |
* buidl: remove unused lodash.isplainobject * build: remove no more needed lodash.isplainobject types * build: add missing json-patch * build: remove no more used require-all * build: remove no more used istanbul * build: remove no more used json * chore: move types to dev dependencies * build: apply npm dedupe * build: upgrade typescript to v5 (#2337) * build: upgrade typescript to v5 * style: update eslint to support latest typescript and apply it (#2338) * build: move dependencies we use for typing only to dev deps
|
@mgoudy91 I guess ready 4 merge & release :) Note: These changes should NOT be breaking. IMHO we can release it as a patch release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to update multiple dependencies while passing integration tests, basically covering many dependabot issues at once that currently fail integration tests
As part of #2334
Yes, bundle sizes increase for now. This also happened in CDA - will be better later on with rollup!