Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: deprecate legacy client [NONE] #2317

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcolink
Copy link
Member

@marcolink marcolink commented Jun 13, 2024

Summary

With the next major version (12.0.0) we finally will deprecate the old client shape.

Description

From now on, the old client type will be called legacy

Changes

  • All legacy client methods are marked as deprecated
  • The default client will be the plain client
  • Users can opt-in to the legacy client

Motivation and Context

The plain client comes with a list of advantages over the legacy client:

  • Same client API as within the APP SDK (already uses the plain client type)
  • No more waterfall calls
  • Maintainability and velocity as we only need to support a single client shape in the future

ToDo

  • Update Readme
  • Update Tests

Checklist (check all before merging)

  • Both unit and integration tests are passing
  • There are no breaking changes
  • Changes are reflected in the documentation

BREAKING CHANGE: The plain client will become the new default client

@marcolink marcolink requested a review from a team as a code owner June 13, 2024 06:18
@marcolink marcolink marked this pull request as draft June 13, 2024 06:18
@marcolink marcolink force-pushed the major/deprecate-legacy-client branch 3 times, most recently from f97753c to d5b5b7b Compare June 13, 2024 06:31
@marcolink marcolink force-pushed the major/deprecate-legacy-client branch from d5b5b7b to 6191299 Compare July 1, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant