Improve podman build secrets docs / Makefile validatepr description #25111
Conversation
|
I confess, I did not run the full suite of tests before I put this PR up, but I'm pretty sure the 4 failures here are unrelated to my changes? Are there flaky tests here? I noticed 3 of those were timeouts. |
|
Yes these are flakes, your branch seems to based on an older commit. Please rebase to the latest main that should help in terms of machine testing on macos 6ee51c5 (In general before pushing a PR it is always a good idea to rebase to the latest main) |
|
Ha that's embarrassing! Usually I do make sure I've pulled latest main. I started this update weeks ago and made the mistake of trying to wrap it up late last night while tired. My apologies, I'll push a rebase later today. |
Signed-off-by: H Dub <[email protected]>
Signed-off-by: H Dub <[email protected]>
hdub-tech
force-pushed
the
docs/podman-build-secrets
branch
from
204d891 to
bbf00ec
Compare
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, hdub-tech, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
TL;DR:
podman build --secretdocumentation and add examples.validateprtomake helpoutput.Details: After struggling to find a way to build an image without writing a secret to disk first, I did some hunting. This PR is basically a copy/paste from buildah-build.1, with some tweaks to appease the podman project linter and with the addition of some Examples. (I plan to submit a similar PR to containers/buildah to update the
--secrethelp output and add the examples there as well).Note: This "Fixes" #23388 if you go strictly by the Title. However, if you read the comments, it looks like the OP is looking for something more along the lines of using
--secretWITHOUT needing--mount=type=secretmodifications to a Containerfile. This is why I omitted the issue number from the commit description. I am more than willing to modify this if requested.Testing
make binariespassesmake docspasses and edits tosecret.image.mdappear inpodman-build.1.mdandpodman-farm-build.1.md.make validateprpassesmake helpshowsvalidateprDoes this PR introduce a user-facing change?