Fix unescaping octal escape sequence in values of Quadlet unit files #25011
+91
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Moalla <[email protected]>
openshift-ci
bot
added
the
approved
|
Thanks @AhmedMoalla |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AhmedMoalla, giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 04e6488
into
containers:main
79 of 80 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the unit file parser can unescape any escape sequences present in values looked up using the following lookup functions in the
UnitFilestruct:LookupAllArgs,LookupAllKeyValandLookupLastArgs.This operation is done though the utility function
cUnescapeOne. This function was incorrectly ported from the systemd code base in this file: escape.c.This PR aims to fix the implementation of
cUnescapeOnewe have in Podman as it does not work properly when unescaping octal escape sequences.Example:
Does this PR introduce a user-facing change?