fix(deps): update module github.com/cyphar/filepath-securejoin to v0.4.0

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
github.com/cyphar/filepath-securejoin	v0.3.6 -> v0.4.0

---

Release Notes

cyphar/filepath-securejoin (github.com/cyphar/filepath-securejoin)

v0.4.0

Compare Source

This release primarily includes a few minor breaking changes to make the
MkdirAll and SecureJoin interfaces more robust against accidental
misuse.

• SecureJoin(VFS) will now return an error if the provided root is not a
  filepath.Clean'd path.

  While it is ultimately the responsibility of the caller to ensure the root is
  a safe path to use, passing a path like /symlink/.. as a root would result
  in the SecureJoin'd path being placed in / even though /symlink/..
  might be a different directory, and so we should more strongly discourage
  such usage.

  All major users of securejoin.SecureJoin already ensure that the paths they
  provide are safe (and this is ultimately a question of user error), but
  removing this foot-gun is probably a good idea. Of course, this is
  necessarily a breaking API change (though we expect no real users to be
  affected by it).

  Thanks to Erik Sjölund, who initially
  reported this issue as a possible security issue.

• MkdirAll and MkdirHandle now take an os.FileMode-style mode argument
  instead of a raw unix.S_*-style mode argument, which may cause compile-time
  type errors depending on how you use filepath-securejoin. For most users,
  there will be no change in behaviour aside from the type change (as the
  bottom 0o777 bits are the same in both formats, and most users are probably
  only using those bits).

  However, if you were using unix.S_ISVTX to set the sticky bit with
  MkdirAll(Handle) you will need to switch to os.ModeSticky otherwise you
  will get a runtime error with this update. In addition, the error message you
  will get from passing unix.S_ISUID and unix.S_ISGID will be different as
  they are treated as invalid bits now (note that previously passing said bits
  was also an error).

Thanks to the following contributors for helping make this release
possible:

• Aleksa Sarai [email protected]
• Erik Sjölund [email protected]

Signed-off-by: Aleksa Sarai [email protected]

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: renovate[bot]
Once this PR has been reviewed and has the lgtm label, please assign rhatdan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[packit-as-a-service]

Ephemeral COPR build failed. @containers/packit-build please check.

[mtrmac]

This needs opencontainers/runc#4590 .

[mtrmac]

Just so that it is not lost, Podman tests also need updating:

commit 4449a5ad759dc3a917b5fed75334cc3342ed68f2
Author: Miloslav Trmač <[email protected]>
Date:   Tue Jan 14 22:54:19 2025 +0100

    WIP: Update for filepath-securejoin 0.4.0
    
    The root of filepath.* now must exist.
    
    Signed-off-by: Miloslav Trmač <[email protected]>

diff --git a/libpod/container_internal_linux_test.go b/libpod/container_internal_linux_test.go
index 4deb513b8..586c5fc19 100644
--- a/libpod/container_internal_linux_test.go
+++ b/libpod/container_internal_linux_test.go
@@ -18,7 +18,7 @@ func TestGenerateUserPasswdEntry(t *testing.T) {
                        },
                },
                state: &ContainerState{
-                       Mountpoint: "/does/not/exist/tmp/",
+                       Mountpoint: t.TempDir(),
                },
        }
        user, err := c.generateUserPasswdEntry(0)
@@ -44,7 +44,7 @@ func TestGenerateUserGroupEntry(t *testing.T) {
                        },
                },
                state: &ContainerState{
-                       Mountpoint: "/does/not/exist/tmp/",
+                       Mountpoint: t.TempDir(),
                },
        }
        group, err := c.generateUserGroupEntry(0)

[kolyshkin]

Most probably a newer version (0.4.1?) will be released, relaxing the SecureJoin's root requirement (see cyphar/filepath-securejoin#47). Therefore, we can just skip 0.4.0.

[cyphar]

https://github.com/cyphar/filepath-securejoin/releases/tag/v0.4.1

Sorry about that.