-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v5.2-rhel] Add --health-max-log-count, --health-max-log-size, --health-log-destination flags #24216
base: v5.2-rhel
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Honny1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
be250e5
to
2f2a6ed
Compare
AFAIK this requires proper backport Jira cards especially as this will also be in RHEL 9.5, as per Tom comment there this should only be in 5.3 and nerwer and I See no backport requests |
2f2a6ed
to
9975083
Compare
cc: @jnovy |
--health-log-destination flags These flags can affect the output of the HealtCheck log. Currently, when a container is configured with HealthCheck, the output from the HealthCheck command is only logged to the container status file, which is accessible via `podman inspect`. It is also limited to the last five executions and the first 500 characters per execution. This makes debugging past problems very difficult, since the only information available about the failure of the HealthCheck command is the generic `healthcheck service failed` record. - The `--health-log-destination` flag sets the destination of the HealthCheck log. - `none`: (default behavior) `HealthCheckResults` are stored in overlay containers. (For example: `$runroot/healthcheck.log`) - `directory`: creates a log file named `<container-ID>-healthcheck.log` with JSON `HealthCheckResults` in the specified directory. - `events_logger`: The log will be written with logging mechanism set by events_loggeri. It also saves the log to a default directory, for performance on a system with a large number of logs. - The `--health-max-log-count` flag sets the maximum number of attempts in the HealthCheck log file. - A value of `0` indicates an infinite number of attempts in the log file. - The default value is `5` attempts in the log file. - The `--health-max-log-size` flag sets the maximum length of the log stored. - A value of `0` indicates an infinite log length. - The default value is `500` log characters. Add --health-max-log-count flag Signed-off-by: Jan Rodák <[email protected]> Add --health-max-log-size flag Signed-off-by: Jan Rodák <[email protected]> Add --health-log-destination flag Signed-off-by: Jan Rodák <[email protected]> (cherry picked from commit de856da) Signed-off-by: Jan Rodák <[email protected]>
9975083
to
d8eef21
Compare
I have put a hold on this as I don't want this merged until after October 21. That's when the RHEL ZeroDay packaging will occur. The card this will address is: https://issues.redhat.com/browse/RHEL-61962 @Luap99 thanks for the eagle eye on that! |
These flags can affect the output of the HealtCheck log. Currently, when a container is configured with HealthCheck, the output from the HealthCheck command is only logged to the container status file, which is accessible via
podman inspect
. It is also limited to the last five executions and the first 500 characters per execution.This makes debugging past problems very difficult, since the only information available about the failure of the HealthCheck command is the generic
healthcheck service failed
record.The
--health-log-destination
flag sets the destination of the HealthCheck log.none
: (default behavior)HealthCheckResults
are stored in overlay containers. (For example:$runroot/healthcheck.log
)directory
: creates a log file named<container-ID>-healthcheck.log
with JSONHealthCheckResults
in the specified directory.events_logger
: The log will be written with logging mechanism set by events_loggeri. It also saves the log to a default directory, for performance on a system with a large number of logs.The
--health-max-log-count
flag sets the maximum number of attempts in the HealthCheck log file.0
indicates an infinite number of attempts in the log file.5
attempts in the log file.The
--health-max-log-size
flag sets the maximum length of the log stored.0
indicates an infinite log length.500
log characters.Add --health-max-log-count flag
Add --health-max-log-size flag
Add --health-log-destination flag
(cherry picked from commit de856da)
Fixes: https://issues.redhat.com/browse/RHEL-61962
Does this PR introduce a user-facing change?