DO NOT MERGE: Run tests with Zstd compression default #21571

mtrmac · 2024-02-08T18:54:36Z

Inspired by #20633

Does this PR introduce a user-facing change?

do not merge this

openshift-ci · 2024-02-08T18:54:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtrmac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mtrmac]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mtrmac · 2024-02-08T20:35:57Z

Legitimate problems:

podman … push --format=v2s2 … fails with Error: compression using zstd required together with format application/vnd.docker.distribution.manifest.v2+json, which does not support it. Arguably an explicit option on the CLI should override config-file compression defaults, the intent here is clear.
podman … push … docker-archive:… fails with compression using zstd required but the destination only supports MIME types [application/vnd.docker.distribution.manifest.v2+json], none of which support it. Same as above, but there isn’t even an explicit CLI option.

mtrmac · 2024-02-08T23:36:29Z

@giuseppe FYI. I’ll continue investigating this, just noting the Podman-side UI concerns above for now.

packit-as-a-service · 2024-02-12T18:44:07Z

Ephemeral COPR build failed. @containers/packit-build please check.

packit-as-a-service · 2024-02-16T23:44:00Z

Cockpit tests failed for commit 9ce62ea83c221979aff1bd91afe0c002cc73f270. @martinpitt, @jelly, @mvollmer please check.

packit-as-a-service · 2024-02-19T22:22:28Z

Cockpit tests failed for commit 1a9566f043cf084167e5ef3e8e90a1690dc7bead. @martinpitt, @jelly, @mvollmer please check.

giuseppe · 2024-02-21T11:04:35Z

CI is green!

rhatdan · 2024-02-21T11:43:14Z

test/e2e/push_test.go

@@ -371,7 +371,7 @@ var _ = Describe("Podman push", func() {
 	It("podman push to docker-archive", func() {
 		SkipIfRemote("Remote push does not support docker-archive transport")
 		tarfn := filepath.Join(podmanTest.TempDir, "alp.tar")
-		session := podmanTest.Podman([]string{"push", "-q", ALPINE,
+		session := podmanTest.Podman([]string{"push", "-q", ALPINE, "--compression-format=gzip",


Does this require a change in podman or contianers/image?

This is specific to containers.conf. So not c/image; Podman or maybe c/common/libimage.

mtrmac · 2024-02-22T16:22:03Z

🎉 green!

#21793 now contains the test updates we do want to make; the other changes from this PR should not be merged, and instead we should change Podman’s behavior.

mtrmac · 2024-03-01T14:20:14Z

Yes, this PR is now a pure setting change to test behavior with Zstd.

I have separately filed #21903 for testing zstd:chunked .

rhatdan · 2024-03-01T14:40:34Z

Nice work @mtrmac and @giuseppe

mtrmac · 2024-03-01T16:30:14Z

For the record, 7879d59 is all green, with no Podman changes (other than the compression algorithm).

rhatdan · 2024-03-01T18:14:41Z

Yup now we need to ship podman 5.0 and change rawhide to zstd:chunked by default.

Signed-off-by: Miloslav Trmač <[email protected]>

The Go image is too old, at least in the CI images Signed-off-by: Miloslav Trmač <[email protected]>

packit-as-a-service · 2025-01-14T21:17:17Z

Ephemeral COPR build failed. @containers/packit-build please check.

The root of filepath.* now must exist. Signed-off-by: Miloslav Trmač <[email protected]>

> go mod edit -replace github.com/opencontainers/runc=github.com/cyphar/[email protected] per opencontainers/runc#4590 . Signed-off-by: Miloslav Trmač <[email protected]>

Signed-off-by: Miloslav Trmač <[email protected]>

openshift-ci bot added release-note do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 8, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2024

mtrmac mentioned this pull request Feb 8, 2024

Zstd(:chunked) work tracking checklist containers/image#2189

Open

36 tasks

mtrmac force-pushed the try-zstd-default branch from 3e881e9 to c21f477 Compare February 8, 2024 20:35

mtrmac force-pushed the try-zstd-default branch from c21f477 to e4f9cca Compare February 9, 2024 16:59

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2024

mtrmac force-pushed the try-zstd-default branch from e4f9cca to a6a81b6 Compare February 12, 2024 18:35

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2024

mtrmac force-pushed the try-zstd-default branch from a6a81b6 to afd6dac Compare February 12, 2024 19:49

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2024

mtrmac force-pushed the try-zstd-default branch from afd6dac to 91fb0ab Compare February 13, 2024 18:34

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2024

mtrmac force-pushed the try-zstd-default branch from 91fb0ab to 9ce62ea Compare February 16, 2024 23:06

mtrmac force-pushed the try-zstd-default branch from 9ce62ea to 1a9566f Compare February 19, 2024 21:35

mtrmac force-pushed the try-zstd-default branch from 1a9566f to 4fd011c Compare February 21, 2024 01:57

rhatdan reviewed Feb 21, 2024

View reviewed changes

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 21, 2024

mtrmac force-pushed the try-zstd-default branch from 4fd011c to afb9b70 Compare February 22, 2024 16:13

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2024

mtrmac mentioned this pull request Feb 22, 2024

Adjust some tests to work with Zstd in containers.conf #21793

Merged

mtrmac force-pushed the try-zstd-default branch from afb9b70 to b4a6e65 Compare February 22, 2024 18:47

mtrmac force-pushed the try-zstd-default branch from 7879d59 to cda5994 Compare April 3, 2024 16:21

mtrmac force-pushed the try-zstd-default branch from cda5994 to 8f7a624 Compare July 17, 2024 17:40

mtrmac force-pushed the try-zstd-default branch from 8f7a624 to 8216c80 Compare October 14, 2024 20:19

mtrmac force-pushed the try-zstd-default branch 3 times, most recently from 2529e6e to 9312529 Compare November 28, 2024 20:56

mtrmac force-pushed the try-zstd-default branch 3 times, most recently from 1810e21 to 386ff32 Compare December 14, 2024 00:19

mtrmac force-pushed the try-zstd-default branch 3 times, most recently from 7f4402b to 7b77eb4 Compare January 7, 2025 18:39

mtrmac force-pushed the try-zstd-default branch from 7b77eb4 to 8c5cbc3 Compare January 9, 2025 21:19

mtrmac mentioned this pull request Jan 9, 2025

DO NOT MERGE: Testing https://github.com/containers/image/pull/2680 #24991

Closed

mtrmac force-pushed the try-zstd-default branch from 8c5cbc3 to 9b8d906 Compare January 10, 2025 20:28

mtrmac added 2 commits January 14, 2025 22:10

DO NOT MERGE: Nerf make-and-check-size

faafd4f

Signed-off-by: Miloslav Trmač <[email protected]>

HACK: Don't test on Fedora 40

7f46a00

The Go image is too old, at least in the CI images Signed-off-by: Miloslav Trmač <[email protected]>

mtrmac force-pushed the try-zstd-default branch from 9b8d906 to ded524f Compare January 14, 2025 21:13

mtrmac force-pushed the try-zstd-default branch from ded524f to e9311ac Compare January 14, 2025 21:30

mtrmac added 5 commits January 14, 2025 22:56

WIP: Update for filepath-securejoin 0.4.0

6c8af04

The root of filepath.* now must exist. Signed-off-by: Miloslav Trmač <[email protected]>

DO NOT MERGE: Update runc for securejoin API change

77cf164

> go mod edit -replace github.com/opencontainers/runc=github.com/cyphar/[email protected] per opencontainers/runc#4590 . Signed-off-by: Miloslav Trmač <[email protected]>

Test with current c/storage and c/image

6a78b52

Signed-off-by: Miloslav Trmač <[email protected]>

HACK: switch the compression to zstd

5b71b9b

Signed-off-by: Miloslav Trmač <[email protected]>

Update the expected default compression algorithm

681a48d

Signed-off-by: Miloslav Trmač <[email protected]>

mtrmac force-pushed the try-zstd-default branch from e9311ac to 681a48d Compare January 14, 2025 21:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DO NOT MERGE: Run tests with Zstd compression default #21571

DO NOT MERGE: Run tests with Zstd compression default #21571

mtrmac commented Feb 8, 2024

openshift-ci bot commented Feb 8, 2024

mtrmac commented Feb 8, 2024

mtrmac commented Feb 8, 2024

packit-as-a-service bot commented Feb 12, 2024

packit-as-a-service bot commented Feb 16, 2024

packit-as-a-service bot commented Feb 19, 2024

giuseppe commented Feb 21, 2024

rhatdan Feb 21, 2024

mtrmac Feb 22, 2024

mtrmac commented Feb 22, 2024

mtrmac commented Mar 1, 2024

rhatdan commented Mar 1, 2024

mtrmac commented Mar 1, 2024

rhatdan commented Mar 1, 2024

packit-as-a-service bot commented Jan 14, 2025

DO NOT MERGE: Run tests with Zstd compression default #21571

Are you sure you want to change the base?

DO NOT MERGE: Run tests with Zstd compression default #21571

Conversation

mtrmac commented Feb 8, 2024

Does this PR introduce a user-facing change?

openshift-ci bot commented Feb 8, 2024

mtrmac commented Feb 8, 2024

mtrmac commented Feb 8, 2024

packit-as-a-service bot commented Feb 12, 2024

packit-as-a-service bot commented Feb 16, 2024

packit-as-a-service bot commented Feb 19, 2024

giuseppe commented Feb 21, 2024

rhatdan Feb 21, 2024

Choose a reason for hiding this comment

mtrmac Feb 22, 2024

Choose a reason for hiding this comment

mtrmac commented Feb 22, 2024

mtrmac commented Mar 1, 2024

rhatdan commented Mar 1, 2024

mtrmac commented Mar 1, 2024

rhatdan commented Mar 1, 2024

packit-as-a-service bot commented Jan 14, 2025