Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare to support libkrunfw 4.x #141

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Prepare to support libkrunfw 4.x #141

merged 3 commits into from
Aug 10, 2023

Conversation

slp
Copy link
Contributor

@slp slp commented Aug 3, 2023

This PR sets up the stage to support libkrunfw 4.x, which bundles a 6.4.x kernel. This is a significant update for two reasons:

  • Kernel load and entry addresses no longer match, so we need to treat them independently, meaning we needed to break the API/ABI of libkrunfw.
  • We've switched to a new patch series implementing datagram support for vsock, which seems very close to be accepted. This allows us to keep TSI around indefinitely, but means we needed to revamp out vsock device implementation around the semantics of this patch set.

slp added 3 commits August 3, 2023 15:43
There's a new patch series implementing datagram support into vsock
which seems closer to get merged "[PATCH RFC net-next v4 0/8]
virtio/vsock: support datagrams" (https://lkml.org/lkml/2023/6/9/1490).

Change our vsock/TSI implementation to use the semantics of that patch
series.

Signed-off-by: Sergio Lopez <[email protected]>
Since Linux 6.4, load and entry addresses doesn't match, so we're
required to do the right thing and treat them independently. For this,
libkrunfw 4.x.x has already extended krunfw_get_kernel() to return this
information, so we need to change the library call, extend the
kernel_bundle to include a field for storing the entry address, and use
it where appropriate.

This also implies we need to bump KRUNFW_MIN_VERSION from 3 to 4.

Signed-off-by: Sergio Lopez <[email protected]>
Bump minor version to reflect the dependency on a newer libkrunfw
version (> 4.x), now at v1.6.0.

Signed-off-by: Sergio Lopez <[email protected]>
@slp slp merged commit 1168fb9 into containers:main Aug 10, 2023
4 checks passed
@slp slp deleted the new-vsock-kernel branch August 10, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants