Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass environment variable(s) to microVM #58

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Conversation

EduM22
Copy link
Contributor

@EduM22 EduM22 commented Feb 4, 2024

Added the ability to pass environment variable(s) to the microVM when starting it.

@slp
Copy link
Collaborator

slp commented Feb 6, 2024

Thanks for your contribution. Could you please remove the third empty commit?

@EduM22
Copy link
Contributor Author

EduM22 commented Feb 6, 2024

Thanks for your contribution. Could you please remove the third empty commit?

how do I do it?, Is it easier to create a new pull request?

@ericcurtin
Copy link

Thanks for your contribution. Could you please remove the third empty commit?

how do I do it?, Is it easier to create a new pull request?

git rebase -i HEAD~3

is a useful tool if you want to change one of the last three commits. Or "drop" one in this case.

Although if the empty commit was at the HEAD, it's simpler to do:

git reset --hard HEAD~

and then a:

git push -f

people create new PRs sometimes to redo things, which is ok, but it's something you rarely have to do.

@EduM22
Copy link
Contributor Author

EduM22 commented Feb 12, 2024

Thanks for your contribution. Could you please remove the third empty commit?

how do I do it?, Is it easier to create a new pull request?

git rebase -i HEAD~3

is a useful tool if you want to change one of the last three commits. Or "drop" one in this case.

Although if the empty commit was at the HEAD, it's simpler to do:

git reset --hard HEAD~

and then a:

git push -f

people create new PRs sometimes to redo things, which is ok, but it's something you rarely have to do.

Thanks for the help.

@slp is it up to spec now?

@h7io
Copy link

h7io commented Jun 9, 2024

Hey guys,

anything holding this up?

@slp
Copy link
Collaborator

slp commented Jun 10, 2024

Sorry, I lost track of this one. LGTM, merging it.

@slp slp merged commit 765614c into containers:main Jun 10, 2024
1 check passed
@EduM22 EduM22 deleted the feat/set-env branch June 10, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants