update deps (go-iptables, cni) #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Winship <[email protected]>
danwinship
force-pushed
the
update-deps
branch
from
3a39664 to
fc4ad22
Compare
Signed-off-by: Dan Winship <[email protected]>
danwinship
force-pushed
the
update-deps
branch
from
fc4ad22 to
06ba001
Compare
danwinship
commented
Aug 28, 2024
| @@ -74,7 +74,8 @@ var _ = Describe("Loopback", func() { | |||
| session, err := gexec.Start(command, GinkgoWriter, GinkgoWriter) | |||
| Expect(err).NotTo(HaveOccurred()) | |||
|
|
|||
| Eventually(session).Should(gbytes.Say(`{.*}`)) | |||
| // "(?s)" turns on the "s" flag, making "." match newlines too. | |||
| Eventually(session).Should(gbytes.Say(`(?s){.*}`)) | |||
There was a problem hiding this comment.
Clearly this was intended to match the result as a whole, but actually, it was only matching
"dns": {}
because that was the only place where there was a { followed by a } on the same line. And then containernetworking/cni#1039 broke that...
mmorel-35
approved these changes
Aug 29, 2024
squeed
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting this out from #935 for clarity / ease of debugging.
Closes #1068
cc @squeed