Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix faulty json.Marshal behavior for embeds types.NetConf #1097

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

s1061123
Copy link
Contributor

@s1061123 s1061123 commented Jun 3, 2024

Fix #1096

@coveralls
Copy link

coveralls commented Jun 3, 2024

Coverage Status

coverage: 63.69%. remained the same
when pulling 499596a on s1061123:fix/1096
into 73debca on containernetworking:main.

Copy link
Member

@LionelJouin LionelJouin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way the users would need to change types.NetConf with types.NetConfType: https://go.dev/play/p/j2wjAgA_s-K
The current way would still not work: https://go.dev/play/p/fHVOmTrH8p_K

@s1061123 s1061123 changed the title Fix faulty json.Marshal behavior for embeds types.NetConf [WIP]Fix faulty json.Marshal behavior for embeds types.NetConf Jun 3, 2024
@s1061123 s1061123 changed the title [WIP]Fix faulty json.Marshal behavior for embeds types.NetConf Fix faulty json.Marshal behavior for embeds types.NetConf Jun 3, 2024
@s1061123
Copy link
Contributor Author

s1061123 commented Jun 3, 2024

@LionelJouin Updated to avoid to change user side code.

Copy link
Member

@LionelJouin LionelJouin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s1061123
Copy link
Contributor Author

s1061123 commented Jun 4, 2024

@squeed PTAL?

@squeed squeed merged commit 6e57c2e into containernetworking:main Jun 10, 2024
5 checks passed
@s1061123 s1061123 deleted the fix/1096 branch June 10, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faulty json.Marshal behavior for structs that embeds types.NetConf since v1.2.0
4 participants