-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix faulty json.Marshal behavior for embeds types.NetConf #1097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way the users would need to change types.NetConf
with types.NetConfType
: https://go.dev/play/p/j2wjAgA_s-K
The current way would still not work: https://go.dev/play/p/fHVOmTrH8p_K
@LionelJouin Updated to avoid to change user side code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good: https://go.dev/play/p/7ncmsg8-uL0
Signed-off-by: Tomofumi Hayashi <[email protected]>
@squeed PTAL? |
Fix #1096