Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix workflow warnings #1037

Closed
wants to merge 1 commit into from
Closed

fix workflow warnings #1037

wants to merge 1 commit into from

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Oct 30, 2023 •
edited
Loading

This is executing checkout first.

Signed-off-by: Matthieu MOREL [email protected]

@coveralls
Copy link

coveralls commented Oct 30, 2023 •
edited
Loading

Coverage Status

coverage: 70.133%. remained the same
when pulling 4b6071e on mmorel-35:patch-1
into b62753a on containernetworking:main.

squeed
squeed reviewed Nov 6, 2023
View reviewed changes
Copy link
Member

@squeed squeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, do we want to do this? I've seen a lot of projects use old versions in go.mod.

@squeed squeed self-requested a review November 6, 2023 16:08
@mmorel-35
Copy link
Contributor Author

actions/setup-go provides a cache for for go dependencies and the cache key is based on the go.sum so the actions/checkout needs to happen before

@mmorel-35
Copy link
Contributor Author

I removed the go-version-file so only the ordering of action is left.

@mmorel-35
fix workflow warnings
4b6071e 
Signed-off-by: Matthieu MOREL <[email protected]>
@mmorel-35 mmorel-35 closed this by deleting the head repository Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed Awaiting requested review from squeed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmorel-35 @coveralls @squeed