Add PHP 8.4 to workflows #65
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
=========================================
Coverage 86.80% 86.80%
Complexity 167 167
=========================================
Files 15 15
Lines 379 379
=========================================
Hits 329 329
Misses 50 50 ☔ View full report in Codecov by Sentry. |
andypost
force-pushed
the
ci-8.4
branch
2 times, most recently
from
e0f13f6
to
f3189ae
Compare
.github/workflows/ci.yml
Outdated
| @@ -115,6 +121,10 @@ jobs: | |||
| extensions: ${{ env.PHP_EXTENSIONS }} | |||
| ini-values: ${{ matrix.php-ini-values }} | |||
|
|
|||
| - name: Update composer to snapshot | |||
| if: matrix.php-version == '8.4' | |||
| run: composer self-update --snapshot | |||
There was a problem hiding this comment.
Until 2.7.8 is out 8.4 should use snapshot jsonrainbow/json-schema#717 (comment)
There was a problem hiding this comment.
Somehow tools: composer:snapshot does not work
There was a problem hiding this comment.
Fixed by passing value from matrix
.github/workflows/ci.yml
Outdated
| tools: composer:snapshot | ||
| dependencies: highest | ||
| codecov: true | ||
| php-ini-values: zend.assertions=1, opcache.enable=1, opcache.enable_cli=1, opcache.optimization_level=-1, opcache.jit_buffer_size=4096M, opcache.jit=1205 |
There was a problem hiding this comment.
JIT settings got changes https://php.watch/versions/8.4/opcache-jit-ini-default-changes
But looks pcov is not updated or codecov is not compatible with JIT as there's in logs
Run composer self-update --snapshot
PHP Warning: JIT is incompatible with third party extensions that override zend_execute_ex(). JIT disabled. in Unknown on line 0
There was a problem hiding this comment.
We don't need to run code coverage on PHP 8.4 right now, if that helps. I don't think it's necessary to test with JIT either.
There was a problem hiding this comment.
Thank you, it was pcov which ruined JIT, also adjusted variables passed to job!
andypost
force-pushed
the
ci-8.4
branch
2 times, most recently
from
05e6040
to
daa4dc0
Compare
new limit |
Follow-up to #64 (comment)