Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Symfony 7 (4.x) #308

Merged
merged 8 commits into from
Apr 5, 2024
Merged

Allow Symfony 7 (4.x) #308

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
95d1076
Allow Symfony 7 (4.x)
weitzman Apr 2, 2024
4d340bf
Comply with parent return type
weitzman Apr 4, 2024
0cbe71c
Rename method so it doesnt override parent
weitzman Apr 4, 2024
0054e20
Set the platform PHP version to something that is acceptable to Symfo…
Apr 5, 2024
0ad2abb
Add -n to the global-options-only test, so that it does not hang if t…
Apr 5, 2024
494cd05
Revert https://github.com/consolidation/annotated-command/pull/306/files
Apr 5, 2024
7b3939a
Annotated commands that extend the AnnotatedCommand class (should be …
Apr 5, 2024
d88c67e
Update versions used in test matrix
Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/src/ExampleAnnotatedCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public function myEcho($one, $two = '', $multiple = [], $flip = false)
* @usage bet alpha --flip
* Concatenate "alpha" and "bet".
*/
protected function execute(InputInterface $input, OutputInterface $output)
protected function myEchoAnnotated(InputInterface $input, OutputInterface $output)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method must be named execute for this test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, methods named execute will have to add a return type hint.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did that, seems green now, I guess old versions are passing because it is okay to add a function return type in an overriding class even if the base class didn't have it.

{
$one = $input->getArgument('one');
$two = $input->getArgument('two');
Expand Down
Loading