Contract redesign #931
Draft
Contract redesign #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 2, 2024 20:35
raulk
reviewed
May 15, 2024
Comment on lines
+12
to
+13
| /// @notice Checks if the component is bootstrapped | ||
| function bootstrapped() external view returns(bool); |
There was a problem hiding this comment.
This is better placed in a Lifecycle facet and generalized as a stage() method that returns the lifecycle stage of a subnet.
contracts/src/interfaces/ISubnet.sol
Outdated
Comment on lines
4
to
8
| /// @title Subnet interface | ||
| interface ISubnet { | ||
| /// @notice Checks if the subnet is now bootstrapped | ||
| function bootstrapped() external view returns(bool); | ||
| } |
There was a problem hiding this comment.
Could you elaborate on what responsibility/scope this interface would hold going forward?
Comment on lines
+19
to
+20
| /// @notice Deposit into the genesis balance of the address | ||
| function deposit(SubnetGenesis storage self, address addr, uint256 amount) internal { |
There was a problem hiding this comment.
This OOP-style pattern is nice, since LibSubnetGenesis can be associated with the SubnetGenesis type via using to write code like this:
using LibSubnetGenesis for SubnetGenesis;
genesis.deposit(addr, amount);
Comment on lines
+23
to
+29
| if (exists) { | ||
| self.balances.set(addr, existingAmount + amount); | ||
| } else { | ||
| self.balances.set(addr, amount); | ||
| } | ||
|
|
||
| self.circSupply += amount; |
There was a problem hiding this comment.
This can be simplified by doing the addition to circSupply sooner, and using an early return in the if. But it's probably clearer this way.
| @@ -6,3 +6,7 @@ pragma solidity ^0.8.23; | |||
| enum ConsensusType { | |||
| Fendermint | |||
| } | |||
|
|
|||
| enum Consensus { | |||
| ProofOfPower | |||
There was a problem hiding this comment.
What exactly is ProofOfPower?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial POC for contract redesign. Refer to
contract-redesign.mdfor the high level idea and please comment.This PR partially implements the ideas:
LibStakingtoLibPowerChangethat usepowerto replacecollateralandfederatedPower. The caller facet can decide whatpoweris