Unify flatten_*op rules into flatten_generic #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! There is also On the topic, we could probably remove Should be trivial (we have introduction rules for minuseq as well), but might be a job for a seperate PR. |
@ozgurakgun I've pushed a commit for this onto this PR |
niklasdewally
approved these changes
Jan 10, 2025
Instead, use `flatten_generic` to flatten `Neg` expressions, and `introduce_minuseq_from_aux_var` and `introduce_minuseq_from_eq` to create FlatMinusEq expressions. This is consistent with other expressions, which have simpler introduction functions that expect flat input, and rely on `flatten_generic` to make the input flat.
niklasdewally
force-pushed
the
unify-flatten
branch
from
926299d to
d793ded
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any reason not to do this? @niklasdewally