tests: disable rewrite_solve_xyz_parameterized by default #572
Conversation
niklasdewally
force-pushed
the
nik/pr/disable-rewrite-parametric-test
branch
from
dab5b76 to
5290bc1
Compare
niklasdewally
changed the title
The rewrite_solve_xyz_paramterized test case is relatively slow, so disable it by default. This significantly improves the time taken to run `cargo test` locally. The Rust book recommends using #[ignore] to disable expensive tests by default [1]. These can be re-enabled using `cargo test -- --ignored` / `cargo test -- --including-ignored`. Add `quick` and `all` parameters to the test CI to run both default tests and all tests (including ignored ones). [1]: https://doc.rust-lang.org/book/ch11-02-running-tests.html#ignoring-some-tests-unless-specifically-requested
niklasdewally
force-pushed
the
nik/pr/disable-rewrite-parametric-test
branch
from
5290bc1 to
b8f0794
Compare
|
Alternatively we could remove this test case, don't think it does much? |
|
Happy to remove the test case. Separately, I like the idea of having infrastructure to select which test to run depending on how expensive the test is though. In Conjure I optionally add a rough expected time (in seconds) for each test case. Then running Could be better than the coarse grained quick/all. Quick can then be an alias for <=1 or whatever and all can be actually all. @EEJDempster @Soph1514 for info. |
Should I close this PR and delete the test case instead, or is this approach to quick/all fine for now? |
As discussed in #572, this test case is relatively slow, and brings little value, so we should remove it. This improves `cargo test` run-times.
|
PR #573 deletes this test case instead. |
|
Fine for now, we delete the test case and merge this as well. But can you please make an issue with the finer grained approach I write above? |
|
Actually maybe we don't need to merge this yet? Thanks for the issue. |
|
Documented in issue #574 |
The rewrite_solve_xyz_paramterized test case is relatively slow, so disable it by default. This significantly improves the time taken to run
cargo testlocally.The Rust book recommends using #[ignore] to disable expensive tests by default 1. These can be re-enabled using
cargo test -- --ignored/cargo test -- --including-ignored.Add
quickandallparameters to the test CI to run both default tests and all tests (including ignored ones).