CUP-1584 Stored Procedure support #1410
Conversation
|
|
1 similar comment
|
|
| case STORED_PROCEDURE: | ||
| log.trace("Starting in STORED PROCEDURE mode"); | ||
| partitions.add(Collections.singletonMap(JdbcSourceConnectorConstants.STORED_PROCEDURE, | ||
| JdbcSourceConnectorConstants.STORED_PROCEDURE)); |
There was a problem hiding this comment.
break; is missed here, maybe that could be the reason of the error "message": "Invalid value storedprocedure for configuration mode: String must be one of: , bulk, timestamp, incrementing, timestamp+incrementing"
| @@ -179,6 +186,10 @@ public void start(Map<String, String> properties) { | |||
| partitions.add(Collections.singletonMap(JdbcSourceConnectorConstants.QUERY_NAME_KEY, | |||
| JdbcSourceConnectorConstants.QUERY_NAME_VALUE)); | |||
| break; | |||
| case STORED_PROCEDURE: | |||
There was a problem hiding this comment.
The upper condition is
if (mode.equals(JdbcSourceTaskConfig.MODE_INCREMENTING) || mode.equals(JdbcSourceTaskConfig.MODE_TIMESTAMP) || mode.equals(JdbcSourceTaskConfig.MODE_TIMESTAMP_INCREMENTING)) {
does it mean that we will not get here in any case?
|
I guess there is a little confusion in terms of modes. My suggestion is to leave the existing display modes, which are "bulk, timestamp, incrementing and timestamp+incrementing" and add a new querier mode to have "query, table and storedprocedure". In our case bulk with storedprocedure should work fine |
pablodc00
force-pushed
the
CUP-1584-stored-procedure
branch
2 times, most recently
from
d56f18f
to
6f1b8ae
Compare
pablodc00
force-pushed
the
CUP-1584-stored-procedure
branch
from
6f1b8ae
to
faf31e0
Compare
Problem
The connector does not support reading from Stored Procedures
Solution
Added support for reading from Stored Procedure
Does this solution apply anywhere else?
If yes, where?
Test Strategy
Testing done:
Release Plan