Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing JDBC Connector build for macOS Monterey 12. #1350

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ManasjyotiSharma
Copy link
Member

@ManasjyotiSharma ManasjyotiSharma commented Jul 8, 2023

Problem

  1. Postgres ITs were failing with segmentation fault.
  2. Two of the UTs are flaky; this issue is not specific to macOS alone rather happeing on Linux as well.

Solution

  1. Fixing the PG segmentation fault by following the solution as mentioned here; namely:
  <dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>io.zonky.test.postgres</groupId>
        <artifactId>embedded-postgres-binaries-bom</artifactId>
        <version>11.13.0</version>
        <type>pom</type>
        <scope>import</scope>
      </dependency>
    </dependencies>
  </dependencyManagement>

  <dependencies>
    <dependency>
      <groupId>io.zonky.test</groupId>
      <artifactId>embedded-postgres</artifactId>
      <version>1.3.1</version>
      <scope>test</scope>
    </dependency>
  </dependencies>

Additionally add following into ~/.zprofile:

export LC_ALL=en_US.UTF-8
export LANG=en_US.UTF-8
  1. Disabling the two flaky UTs for now. Filed Jira (ref) to track fixing them.
Does this solution apply anywhere else?
  • yes
  • no
Testing done:
  • Unit tests
  • Integration tests
  • System tests
  • Manual tests

@cla-assistant
Copy link

cla-assistant bot commented Aug 1, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant