Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read Correct metadata for SAP Hana views #1215

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

lennartfries
Copy link

@lennartfries lennartfries commented Jul 8, 2022

Problem

SAP Hana can not see direct views

Solution

Reopens Solutions of #1103

Does this solution apply anywhere else?
  • yes
  • no
If yes, where?

Test Strategy

Testing done:
  • [ x] Unit tests
  • Integration tests
  • System tests
  • Manual tests

Release Plan

@lennartfries lennartfries requested a review from a team as a code owner July 8, 2022 13:07
@CLAassistant
Copy link

CLAassistant commented Jul 8, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@lennartfries lennartfries changed the title Read Correct metadata for SAP Hana views (Reopen of https://github.co… Read Correct metadata for SAP Hana views Jul 8, 2022
Copy link
Member

@sagarrao12 sagarrao12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @lennartfries Very minor changes suggested. Also, I don't see tests for this change. Could you plz add unit tests for this? Thanks!

pom.xml Outdated Show resolved Hide resolved
@jomach
Copy link

jomach commented Oct 9, 2022

@sagarrao12 can we merge this now ?

Copy link
Member

@sagarrao12 sagarrao12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @mukkachaitanya / @ypmahajan could you also take a look once. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants