Use built-in "CreateReadOnlySpanFromNullTerminated" on NET6-specific path #2207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a .NET6-specific implementation of
PtrToStringUTF8
to use the built-inMemoryMarshal.CreateReadOnlySpanFromNullTerminated()
function to satisfy the below existing inline comment in the source:This API was added in .NET6 for this purpose (when an interop call only returns a pointer and the length of the underlying null-terminated string is unknown) - dotnet/runtime#40202. The internal source uses
strlen()
which internally delegates toSpanHelpers.IndexOfNullByte
which is heavily optimized with vectorization or other special cases.Performance is comparable. I have run the unit tests locally to validate the change but am unable to run the integration tests.
Benchmarks (using .NET8 runtime)