PR comment cleanup

confio · Oct 1, 2022 · e9542d3 · e9542d3
1 parent ef330cf
commit e9542d3
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 71 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/contracts/callback-capturer/Cargo.toml b/contracts/callback-capturer/Cargo.toml
@@ -27,6 +27,5 @@ serde = { version = "1.0.103", default-features = false, features = ["derive"] }
 thiserror = { version = "1.0.23" }
 
 [dev-dependencies]
-anyhow = "1"
 assert_matches = "1"
 derivative = "2"
diff --git a/contracts/callback-capturer/NOTICE b/contracts/callback-capturer/NOTICE
diff --git a/contracts/callback-capturer/README.md b/contracts/callback-capturer/README.md
diff --git a/contracts/simple-ica-controller/src/contract.rs b/contracts/simple-ica-controller/src/contract.rs
@@ -21,7 +21,6 @@ pub fn instantiate(
     info: MessageInfo,
     _msg: InstantiateMsg,
 ) -> StdResult<Response> {
-    // we store the reflect_id for creating accounts later
     let cfg = Config { admin: info.sender };
     CONFIG.save(deps.storage, &cfg)?;
 
@@ -46,9 +45,9 @@ pub fn execute(deps: DepsMut, env: Env, info: MessageInfo, msg: ExecuteMsg) -> S
             callback_id,
         } => execute_ibc_query(deps, env, info, channel_id, msgs, callback_id),
         ExecuteMsg::SendFunds {
-            ica_channel_id: reflect_channel_id,
+            ica_channel_id,
             transfer_channel_id,
-        } => execute_send_funds(deps, env, info, reflect_channel_id, transfer_channel_id),
+        } => execute_send_funds(deps, env, info, ica_channel_id, transfer_channel_id),
     }
 }
 
@@ -164,7 +163,7 @@ pub fn execute_send_funds(
     deps: DepsMut,
     env: Env,
     mut info: MessageInfo,
-    reflect_channel_id: String,
+    ica_channel_id: String,
     transfer_channel_id: String,
 ) -> StdResult<Response> {
     // intentionally no auth check
@@ -184,7 +183,7 @@ pub fn execute_send_funds(
     }
 
     // load remote account
-    let data = ACCOUNTS.load(deps.storage, &reflect_channel_id)?;
+    let data = ACCOUNTS.load(deps.storage, &ica_channel_id)?;
     let remote_addr = match data.remote_addr {
         Some(addr) => addr,
         None => {

diff --git a/contracts/simple-ica-controller/src/ibc.rs b/contracts/simple-ica-controller/src/ibc.rs
@@ -139,6 +139,7 @@ fn acknowledge_dispatch(
             // Send IBC packet ack message to another contract
             let res = res
                 .add_attribute("callback_id", &id)
+                //  In production, you will want to think about gas limits for this callback.
                 .add_message(ReceiveIbcResponseMsg { id, msg }.into_cosmos_msg(sender)?);
             Ok(res)
         }