feat: Add link_package_from_archive
#937
Open
+268
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelzw
changed the title
link_package_from_packagelink_package_from_archive
baszalmstra
reviewed
Nov 14, 2024
| .await | ||
| .unwrap(); | ||
|
|
||
| insta::assert_yaml_snapshot!(paths); |
There was a problem hiding this comment.
Can you give the snapshot a name? This guarentees that the snapshot is properly linked to the loop iteration. Otherwise we might get flaky tests later.
| "25c755b97189ee066576b4ae3999d5e7ff4406d236b984742194e63941838dcd" | ||
| ), | ||
| ( | ||
| "https://conda.anaconda.org/conda-forge/linux-aarch64/bzip2-1.0.8-hf897c2e_4.tar.bz2", |
There was a problem hiding this comment.
I think this package contains symlinks which won't work on windows. Can you use another package?
There was a problem hiding this comment.
Or if possible a smaller package stored in the repo? Premature opimization perhaps, but I want the tests to run very fast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It would be nice to be able to install directly from a package file instead of needing to have the package available in the cache.