-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: normalize package names where applicable #285
feat: normalize package names where applicable #285
Conversation
Not really sure if we need to keep the original form or not. And my second question would be that if we do this for all MatchSpecs, are we going to loose a lot of performance (in repodata we can assume that they are already lowercase, I guess). |
Yeah I was also wondering if it is useful to keep the source representation. I was also thinking that it might be good to use The overhead of |
@baszalmstra Thanks for working on this! I am also unsure if it is useful within rattler to keep the source representation. As a user, the behavior I'd like to see is |
87dc4cf
to
1e66bbe
Compare
I changed this PR quite a bit. |
This PR fixes an issue where package names of conda are always lowercase but they don't have to be lowercase in specs. This PR introduces a new type
PackageName
that holds both the original source package name as well as the normalized (lowercased) package name. The type is used throughout the rest of the code base which makes this a slightly breaking change.This should fix the issue reported here.