Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mmap permission denied #273

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Conversation

baszalmstra
Copy link
Collaborator

@baszalmstra baszalmstra commented Jul 27, 2023

This PR is an attempt to fix the issue described in prefix-dev/pixi#234.

After some investigation, it appears that specifically on macOS it is not allowed to memory map a file that was mounted into an x86 based docker image. This PR adds more diagnostic errors and falls back to reading the entire file to memory if memory mapping fails. In the future it might be nice to stream the file in and do the replacement on the fly.

@baszalmstra baszalmstra force-pushed the fix/soft_link_error branch 3 times, most recently from 8c89533 to 204f3bb Compare July 28, 2023 20:32
@baszalmstra
Copy link
Collaborator Author

Although this is not strictly required I think it cleans up the code, so Ill merge anyway.

@baszalmstra baszalmstra merged commit cede9c1 into conda:main Jul 31, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant