Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: MDsrv version 0.3.5 #3553

Merged
merged 5 commits into from
Aug 14, 2017
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions recipes/mdsrv/meta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
{% set name = "MDsrv" %}
{% set version = "0.3.5" %}
{% set sha256 = "3dd218ec0d62cf47061699b8ab33715d6875fad824091f2ab37e546467fef0c3" %}


package:
name: {{ name|lower }}
version: {{ version }}

source:
fn: {{ name }}-{{ version }}.tar.gz
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz
sha256: {{ sha256 }}

build:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the package's setup.py it appears that there is a python entry_point. Please add it here:

https://conda.io/docs/building/meta-yaml.html#python-entry-points

https://github.com/arose/mdsrv/blob/master/setup.py#L47-L48

number: 0
script: python setup.py install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use:

script: python setup.py install --single-version-externally-managed --record record.txt

https://github.com/conda-forge/staged-recipes/blob/master/recipes/example/meta.yaml#L26

since it appears that this package uses setuptools.


requirements:
build:
- python
- cython
- numpy >=1.11
- msinttypes # [win and py2k]
- setuptools
- flask
- scipy
- zlib
- mdtraj
- mdanalysis # [not win and py2k]

run:
- python
- setuptools
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is setuptools an actual runtime dependency?

- numpy >=1.11
- flask
- mdtraj
- mdanalysis # [not win and py2k]

test:
imports:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test the command line interface:

https://conda.io/docs/building/meta-yaml.html#test-commands

- mdsrv

about:
home: https://github.com/arose/mdsrv
license: MIT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add: license_file: LICENSE

summary: "Simple server to visualize remote trajectories."
description: |
MDsrv is a simple server that enables remote access to coordinate trajectories from molecular dynamics simulations. It can be used together with the NGL Viewer (http://github.com/arose/ngl) to interactively view trajectories of molecular complexes in a web-browser, either within a local network or from anywhere over the internet.
doc_url: https://nglviewer.org/mdsrv
dev_url: https://github.com/arose/mdsrv

extra:
recipe-maintainers:
- j0kaso
- arose
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arose -- are you ok being added as a co-maintainer of the MDsrv package on conda-forge? Your name was added by @j0kaso. Being a co-maintainer would give you write permission to the github repository allowing you to update the package on conda-forge.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I would like to be added as a co-maintainer, thanks